chill-akka support scala 2.12 #266#273
Merged
Merged
Conversation
Closed
Contributor
Author
|
hmm one of travis build failed with a strange error. can i retrigger a travis job ? |
Contributor
|
That is not a strange error, that is the error when there is a mismatch between the compiled class versions and the jdk you are compiling on. In this case, I guess you need java8 for the 2.11 branch, so you need to update that in .travis.yml. |
Contributor
|
@fkowal if you fix this PR to use oraclejdk8 on 2.11 tests in |
fkowal
force-pushed
the
chill_akka_2.12
branch
from
3f193c9 to
c4446bb
Compare
Current coverage is 47.86% (diff: 100%)@@ develop #273 diff @@
==========================================
Files 41 41
Lines 1262 1262
Methods 1224 1224
Messages 0 0
Branches 38 38
==========================================
Hits 604 604
Misses 658 658
Partials 0 0
|
Contributor
Author
|
that helped |
Contributor
|
Thanks! |
fkowal
added a commit
to fkowal/chill
that referenced
this pull request
Jan 5, 2017
(cherry picked from commit 0a481f4)
|
@johnynek I still do not see the chill-akka_2.12 artifact in mavencentral. |
Contributor
|
@johnynek Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.