Backport 2.12 to 0.7.x branch#274
Merged
Merged
Conversation
Contributor
Author
|
@sritchie @isnotinvain review? |
sritchie-stripe
suggested changes
Jan 4, 2017
| ## Maven | ||
|
|
||
| Chill modules are available on Maven Central. The current groupid and version for all modules is, respectively, `"com.twitter"` and `0.7.4` and each scala project is published for `2.10` and `2.11`. Search [search.maven.org](http://search.maven.org/#search%7Cga%7C1%7Cchill) when in doubt. | ||
| Chill modules are available on Maven Central. The current groupid and version for all modules is, respectively, `"com.twitter"` and `0.8.0` and each scala project is published for `2.10`, `2.11` and `2.12`. Search [search.maven.org](http://search.maven.org/#search%7Cga%7C1%7Cchill) when in doubt. |
There was a problem hiding this comment.
do we care about the README on each of these branches reflecting the 0.7.x, etc and proper kryo version?
| @@ -1,23 +1,14 @@ | |||
| import ReleaseTransformations._ | |||
There was a problem hiding this comment.
Are we also going to have to backport the doge release business? I think so.
|
|
||
| override def getRegistration(klass: Class[_]) = | ||
| if (isJavaLambda(klass)) { | ||
| getClassResolver.getRegistration(classOf[ClosureSerializer.Closure]) |
There was a problem hiding this comment.
hmm, odd that this doesn't have coverage even though without it the tests failed.
| @@ -1,9 +1,9 @@ | |||
| resolvers += Resolver.url("sbt-plugin-releases", new URL("http://scalasbt.artifactoryonline.com/scalasbt/sbt-plugin-releases/"))(Resolver.ivyStylePatterns) | |||
|
|
|||
| addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.0") | |||
There was a problem hiding this comment.
we'll need to bump this as well - that'll get covered by the cherry-pick, I guess.
Contributor
Author
There was a problem hiding this comment.
huh, I guess we overlooked this.
|
Huh, on 2.12: |
| override def read(kryo: Kryo, input: Input, typ: Class[ActorRef]): ActorRef = { | ||
| val path = input.readString() | ||
| system.actorFor(path) | ||
| val path = ActorPath.fromString(input.readString()) |
There was a problem hiding this comment.
Oh! Nice, I didn't realize that I DID merge these changes and that they're backwards compatible. Nice.
|
I think there's a race on the build, kick it again but 👍 on the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings e5afee8 to the 0.7.x (Kryo 2.21) branch.