Skip to content

Simplify the Memory platform using Dagon memoization#1836

Merged
johnynek merged 1 commit intodevelopfrom
oscar/simplify_memory_planner_with_dagon
Mar 6, 2018
Merged

Simplify the Memory platform using Dagon memoization#1836
johnynek merged 1 commit intodevelopfrom
oscar/simplify_memory_planner_with_dagon

Conversation

@johnynek
Copy link
Copy Markdown
Contributor

@johnynek johnynek commented Mar 3, 2018

Using Dagon's Memoize.functionK, it is much easier to write recursive memoized functions without threading through the state yourself.

I changed the code here to do that since we will likely want to copy this approach in the spark backend (which I started to do in #1832 ).

@johnynek
Copy link
Copy Markdown
Contributor Author

johnynek commented Mar 3, 2018

@non @erik-stripe can you review? you have the most dagon familiarity.

cc @ianoc @fwbrasil

@ianoc
Copy link
Copy Markdown
Contributor

ianoc commented Mar 6, 2018

Erik's review would be better, but all looks pretty sane to me

@non
Copy link
Copy Markdown

non commented Mar 6, 2018

LGTM 👍

Not having to explicitly thread the memoization through really improves readability!

@johnynek johnynek merged commit abaaeb7 into develop Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants