publish for scalding base missing

[hazel-sudz]

I noticed when pulling down the scalding-core snapshot the scalding-base module was not published. This can be confirmed by looking at https://oss.sonatype.org/content/repositories/snapshots/com/twitter/

I'm not 100% on how sbt works but I think it needs to be listed under the aggregation for

lazy val scalding = Project(id = "scalding", base = file("."))

I tested with ./sbt publishLocal and it seemed to do the trick locally.

[hazel-sudz]

slightly awkward situation: the java8 runtime has dropped some classes that hadoop relies on see: https://issues.apache.org/jira/browse/HADOOP-16590.

this means presumably that any managed cloud services are quickly going to become completely incompatible with scalding if they use recent java8 versions. This is especially problematic because we are pinned to old cascading + old hadoop so we can't pull in the upstream patch.

we can lock the java8 version in CI for now but this is not great. At some point we are going to have to drop support for cascading backend it just seems inevitable.

CC @nownikhil @navinvishy curious on your thoughts. Is it reasonable in the future to expect only support of beam/spark backends?

[hazel-sudz]

I think we want tags here instead of release. The last tag push didn't trigger publish because of this.

[codecov-commenter]

Codecov Report

Merging #1996 (5be9ff0) into develop (e96797b) will increase coverage by 15.85%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##             develop    #1996       +/-   ##
==============================================
+ Coverage      18.06%   33.92%   +15.85%     
- Complexity       284     1175      +891     
==============================================
  Files             78      363      +285     
  Lines           4273    26694    +22421     
  Branches         734     4651     +3917     
==============================================
+ Hits             772     9055     +8283     
- Misses          3352    16292    +12940     
- Partials         149     1347     +1198     

Impacted Files	Coverage Δ
...e/src/main/scala/com/twitter/scalding/Config.scala	33.33% <0.00%> (ø)
...rc/main/scala/com/twitter/scalding/Execution.scala	22.22% <0.00%> (ø)
.../twitter/scalding/ExecutionOptimizationRules.scala	15.92% <ø> (ø)
...src/main/scala/com/twitter/scalding/JobStats.scala	0.00% <ø> (ø)
...ase/src/main/scala/com/twitter/scalding/Mode.scala	9.09% <ø> (ø)
.../src/main/scala/com/twitter/scalding/StatKey.scala	0.00% <ø> (ø)
...src/main/scala/com/twitter/scalding/UniqueID.scala	0.00% <ø> (ø)
...ala/com/twitter/scalding/mathematics/Matrix2.scala	0.00% <0.00%> (ø)
...ain/scala/com/twitter/scalding/typed/Grouped.scala	20.04% <ø> (ø)
...com/twitter/scalding/typed/MultiJoinFunction.scala	0.00% <0.00%> (ø)
... and 306 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96797b...5be9ff0. Read the comment docs.

[johnynek]

Thanks!