This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Fix Storm Tests and ClassCastException in Storm jobs#227
Merged
Conversation
Author
|
I also removed the name parameter from the storm constructor. It's binary incompatible with the old version, but we can help jco through that bump. |
Contributor
There was a problem hiding this comment.
rather this be: must beTrue
Contributor
|
Note the yellow (warning) on some of the client tests: https://travis-ci.org/twitter/summingbird/jobs/11529444#L1042 there are no musts that were checked. |
Author
|
I get that. working on it now. |
johnynek
added a commit
that referenced
this pull request
Sep 19, 2013
Fix Storm Tests and ClassCastException in Storm jobs
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…d225 SketchMap#create improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also removed the Scalacheck from the storm test job. There is some code duplication at play in the
StormLaws; as I add more tests I'll abstract out the required running state.