This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
some samples of generated graphs |
|
Such a dominator! |
Contributor
There was a problem hiding this comment.
add comment here to explain it more.
Contributor
There was a problem hiding this comment.
Change to boolean: mergeableWithSource()?
Outputs to a graphViz
Add law saying no flat maps can live with a source
Adds extra handling in graph to ensure we don't push flat mapped producers down to the source Rename forward/reverse to dependsOn and dependantOf for clarity
Add comments for maybeCollapse and maybeSplit
…hose producers aren't normal merges. Add in a block to disallow a source to be both sides of a merge(or indeed any other node). Fix generator so this doesn't occur. Clean up and encapsulate in a private class more of the separation logic
Contributor
Author
|
Updated to fix an edge case where the MergeProducer that was being depended on by another MergeProducer was a fan out node and so couldn't be collapsed down. Also where the visited nodes having been seen was causing some StormNodes not to be registered |
Contributor
Author
Contributor
There was a problem hiding this comment.
are any of these used? (storm imports)?
Can you audit and remove anything unnneed? It will make it easier to think of using this on other platforms.
Contributor
Author
There was a problem hiding this comment.
Removed nearly all imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the concept of a Planned DAG for storm jobs that can be emitted as a graphviz
Adds a series of laws for this DAG