Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Feature/also tail producer support#423

Merged
johnynek merged 5 commits intodevelopfrom
feature/alsoTailProducerSupport
Jan 21, 2014
Merged

Feature/also tail producer support#423
johnynek merged 5 commits intodevelopfrom
feature/alsoTailProducerSupport

Conversation

@ianoc
Copy link
Copy Markdown
Contributor

@ianoc ianoc commented Jan 21, 2014

No description provided.

@ianoc
Copy link
Copy Markdown
Contributor Author

ianoc commented Jan 21, 2014

@johnynek You can see the changes I had to make to the StripNamedNodes functionalization code here. It looks a bit ugly imo. But I can't see a good way around that. We need to keep the case class + trait after functionalization available

@ianoc
Copy link
Copy Markdown
Contributor Author

ianoc commented Jan 21, 2014

Its green after the magic retry button now

@johnynek
Copy link
Copy Markdown
Contributor

So, just to note here: Most case matches don't need to be updated because AlsoTail extends AlsoProducer, is that your understanding? (entireGraphOf, dependantsOf)?

johnynek added a commit that referenced this pull request Jan 21, 2014
@johnynek johnynek merged commit ba1185d into develop Jan 21, 2014
@johnynek johnynek deleted the feature/alsoTailProducerSupport branch January 21, 2014 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants