Update gem to support frozen string literal#337
Closed
maxwell wants to merge 2 commits into
Closed
Conversation
1) Add magic comment to all rb files 2) Remove using << with strings to prevent modification 3) For the monkey patch to string, we can not set instance state in the String classes, because Strings are now immutable.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As a user of the twitter-text gem, I want to turn on frozen_string_literal for my application, but the twitter-text gem does not support the setting, therefore I can not turn it on for my application.
see: https://www.mikeperham.com/2018/02/28/ruby-optimization-with-one-magic-comment/
for more info.
Solution
Result
Running the tests as
are green.