ABN-298: Dev tooling — FRP proxy, Xdebug, debug mode, README#80
Merged
dgjlindsay merged 1 commit intomainfrom Apr 13, 2026
Merged
ABN-298: Dev tooling — FRP proxy, Xdebug, debug mode, README#80dgjlindsay merged 1 commit intomainfrom
dgjlindsay merged 1 commit intomainfrom
Conversation
6 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly enhances the development environment by introducing Xdebug support, an FRP reverse proxy for HTTPS callbacks, and a comprehensive README update. Key improvements include dynamic environment detection in the Makefile and new scripts for container patching. Feedback focuses on improving error visibility during proxy startup, resolving potential file permission issues in logs, refining Xdebug configuration cleanup to be version-specific, addressing security concerns regarding HTTPS detection headers, and ensuring consistency by using standard Magento CLI commands instead of third-party tools in generated scripts.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…rite - Add FRP reverse proxy (frpc.toml + start-proxy.sh) with GCP Secret Manager fallback for auth token - Patch container's PHP router to trust X-Forwarded-Host for HTTPS detection (FRP terminates TLS but sends X-Forwarded-Proto: http) - Auto-set Magento base URLs to proxy domain via custom-entrypoint.sh (survives container restarts, entrypoint base URL resets) - Install Xdebug automatically (mode=off) during make install - Add make debug target: activates Xdebug + disables all caches for hot reload - make run/stop now manage the FRP proxy lifecycle and print URLs - Auto-detect staging/sandbox environment from gcloud account - Support custom port via make install PORT=<n> - Rewrite README: document full dev workflow including debugging, proxy, and tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dgjlindsay
force-pushed
the
doug/ABN-298-dev-tooling
branch
from
97044f4 to
f8b395c
Compare
Puvendhan
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Development environment improvements for the Magento plugin.
frpc.toml+start-proxy.shwith GCP Secret Manager fallback. Patches PHP router to trustX-Forwarded-Hostfor HTTPS detection and auto-sets Magento base URLs viacustom-entrypoint.sh(survives container restarts)make debugactivates it + disables caches for hot reloadrun,debug,stop,proxy), auto-detect staging/sandbox from gcloud account, custom port supportTest plan
make installcompletes with Xdebug installedmake runstarts proxy and prints URLsmake debugactivates Xdebug, breakpoints work in VSCodemake stopcleans up proxy and resets base URLs🤖 Generated with Claude Code