Skip to content

Filter baseline variables from session persistence#17

Merged
twokidsCarl merged 1 commit intomainfrom
fix/serializer-filter-vars
Apr 8, 2026
Merged

Filter baseline variables from session persistence#17
twokidsCarl merged 1 commit intomainfrom
fix/serializer-filter-vars

Conversation

@twokidsCarl
Copy link
Copy Markdown
Owner

Summary

  • Root cause found: RubyGems ruby_executable_hooks wrapper creates title, content, index, skipped_content, start_line in TOPLEVEL_BINDING. These were saved to values.json on exit and restored on next launch.
  • Fix: Pass baseline_vars to Serializer.save — only user-defined session variables are persisted, pre-existing binding variables are excluded.
  • Cleanup: Removed dirty entries from test/.ruby-claw/values.json

Test plan

  • 98 TUI tests pass
  • Manual: launch claw from test/ dir, verify no stale variables in Binding panel

🤖 Generated with Claude Code

RubyGems executable_hooks wrapper creates local variables (title,
content, index, skipped_content, start_line) in TOPLEVEL_BINDING.
These were being saved to values.json on exit and restored on
next launch, polluting the binding.

Fix: pass baseline_vars to Serializer.save to exclude pre-existing
variables. Only user-defined session variables are persisted.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Warning

Rate limit exceeded

@twokidsCarl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e963dbd5-ad53-460b-8302-dbb9c7995692

📥 Commits

Reviewing files that changed from the base of the PR and between 2ca4471 and 605a596.

📒 Files selected for processing (3)
  • lib/claw/serializer.rb
  • lib/claw/tui/model.rb
  • lib/claw/version.rb
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/serializer-filter-vars

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@twokidsCarl twokidsCarl merged commit aece14d into main Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant