Skip to content

chore: setup GitHub actions to run unit tests#13

Merged
hrchu merged 20 commits intomasterfrom
chore/setup_github_actions_to_run_unit_tests_peter0083
Oct 30, 2021
Merged

chore: setup GitHub actions to run unit tests#13
hrchu merged 20 commits intomasterfrom
chore/setup_github_actions_to_run_unit_tests_peter0083

Conversation

@peter0083
Copy link
Copy Markdown
Contributor

@peter0083 peter0083 commented Oct 18, 2021

  • configure GitHub actions to run unit tests with every commits.

@peter0083 peter0083 added enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted labels Oct 18, 2021
@peter0083 peter0083 requested a review from hrchu October 18, 2021 02:03
@peter0083 peter0083 changed the title chore: setup GitHub actions to run unit tests. chore: setup GitHub actions to run unit tests Oct 18, 2021
@peter0083 peter0083 linked an issue Oct 18, 2021 that may be closed by this pull request
@hrchu
Copy link
Copy Markdown
Member

hrchu commented Oct 18, 2021

Some cases are actually integration tests and cannot run without proper configurations. We might need to rename them to integration_test_xxx.py or something like that.

Copy link
Copy Markdown
Member

@hrchu hrchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz ref three comments, thank you!

name: "Continuous Integration"

on:
push:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be better to run this on each commit, so developers can notice errors as early as possible, i.e.,
on: [push, pull_request]

Comment thread setup.cfg Outdated
install_requires =
httpx==0.18.2
rdflib==5.0.0
pytest==6.2.4
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest isn't required by users. Install it via requirements.txt or tests_require instead.

FYI


strategy:
matrix:
python-version: ['3.7', '3.8']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can hit all non-EOL versions, i.e., 3.7~3.10

…ore/setup_github_actions_to_run_unit_tests_peter0083
@hrchu hrchu merged commit acf8b3f into master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup github action for testing

2 participants