This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Adds travis build with pools turned off#885
Merged
pschorf merged 4 commits intotwosigma:masterfrom Jun 19, 2018
Merged
Conversation
Contributor
Author
|
@pschorf Thoughts on this? |
pschorf
reviewed
Jun 15, 2018
| (let [pools (all-pools db) | ||
| default-pool-name (config/default-pool)] | ||
| (log/info "Pools in the database:" pools ", default pool:" default-pool-name) | ||
| (if default-pool-name |
Contributor
There was a problem hiding this comment.
Would this be better in the config section, so everyone else doesn't have to worry about it?
Contributor
Author
There was a problem hiding this comment.
By "this", do you meany the blank? check?
Contributor
There was a problem hiding this comment.
Right, either replacing blank with nil or failing to load the config.
Sorry for the lack of clarity.
Contributor
Author
|
@pschorf This is ready for another pass |
Contributor
Author
|
@pschorf Any other feedback on this? |
pschorf
approved these changes
Jun 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
--pools={on/off}torun_integration.sh--pools=offWhy are we making these changes?
We want to ensure that changes we make for pools don't break environments that don't have pools.