Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

Comments

Make Group.java use temporal ID by default.#927

Merged
pschorf merged 1 commit intotwosigma:masterfrom
scrosby:outgoing/temporal_uuid_jobclient2
Jul 27, 2018
Merged

Make Group.java use temporal ID by default.#927
pschorf merged 1 commit intotwosigma:masterfrom
scrosby:outgoing/temporal_uuid_jobclient2

Conversation

@scrosby
Copy link
Member

@scrosby scrosby commented Jul 26, 2018

Changes proposed in this PR

  • Make Group.java use new temporal ID by default.

Why are we making these changes?

  • Investigation found that random ID's could be a bottleneck in job submission.
  • Using temporal UUID's would let us increase the job submission rate by 10x-30x, to 1000-3000 jobs/second, if used for commitlatch and by client code.
  • This makes the default fast.

@scrosby scrosby requested a review from pschorf July 26, 2018 19:56
@pschorf pschorf merged commit bea65d9 into twosigma:master Jul 27, 2018
@scrosby scrosby deleted the outgoing/temporal_uuid_jobclient2 branch July 27, 2018 15:47
dposada pushed a commit to dposada/Cook that referenced this pull request Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants