Use DiskImage trait for CD-ROM devices too#236
Merged
twvd merged 1 commit intotwvd:masterfrom Feb 7, 2026
Merged
Conversation
Extends the approach from twvd#211 to also be used for CD-ROMs, allowing more flexibility and code sharing for disk image loading. Also includes some small cleanups to FileDiskImage in how block size multiples are enforced (it's only needed at creation time, no need to store it as a field).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the approach from #211 to also be used for CD-ROMs, allowing more flexibility and code sharing for disk image loading.
Also includes some small cleanups to
FileDiskImagein how block size multiples are enforced (it's only needed at creation time, no need to store it as a field).