Implement a LaserWriter IISC printer emulation#303
Open
demik wants to merge 8 commits intotwvd:masterfrom
Open
Implement a LaserWriter IISC printer emulation#303demik wants to merge 8 commits intotwvd:masterfrom
demik wants to merge 8 commits intotwvd:masterfrom
Conversation
Author
|
I fail to understand the MINGW64 build error. GitHub acting again ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The protocol has been mostly reversed, so here is a PR to implement it in Snow.
There is probably some stuff to improve, but as a first shot I hope this isn't too bad
Thank you for the nice architecture. The SCSI code is really nice, it was easy to implement it. (I did hit a couple of bugs, which were fixed last week)
Couple of notes:
If this is ok, I would like to add a few more things, for example use the nice debug features of Snow (debug paper size, count pages or commands, etc)
Edit: the printer feature needs --feature printer, not sure how that's gonna work with the CI