Skip to content

fix(cardano): Add parameter change proposal outcome#983

Merged
scarmuega merged 1 commit intomainfrom
fix/missing-parameter-change-on-preview
Apr 29, 2026
Merged

fix(cardano): Add parameter change proposal outcome#983
scarmuega merged 1 commit intomainfrom
fix/missing-parameter-change-on-preview

Conversation

@gonzalezzfelipe
Copy link
Copy Markdown
Contributor

@gonzalezzfelipe gonzalezzfelipe commented Apr 29, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated proposal outcome evaluation logic to correctly handle a specific proposal condition, ensuring the proper ratified status is returned.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ddf0d0de-f5b7-467b-b96f-d95fba915211

📥 Commits

Reviewing files that changed from the base of the PR and between 86cc287 and d7f112f.

📒 Files selected for processing (1)
  • crates/cardano/src/hacks.rs

📝 Walkthrough

Walkthrough

A hard-coded proposal hash with index #0 is added to the proposals::preview::outcome function, enabling it to return ProposalOutcome::Ratified(1269) for a specific proposal before falling through to default protocol-based logic.

Changes

Cohort / File(s) Summary
Proposal Hash Interception
crates/cardano/src/hacks.rs
Added match arm for a specific proposal hash (#0) that explicitly returns ProposalOutcome::Ratified(1269) instead of using protocol defaults.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • scarmuega

Poem

🐰 A hash finds its match, oh what a delight!
Proposal votes cast in the warm morning light,
Ratified swift at one-two-six-nine's call,
No protocols needed—this rabbit decoded it all! 🎩✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a proposal outcome for a parameter change on the preview network.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/missing-parameter-change-on-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit e9e4161 into main Apr 29, 2026
12 checks passed
@scarmuega scarmuega deleted the fix/missing-parameter-change-on-preview branch April 29, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants