feat(network): add peersharing protocol module#574
Merged
Conversation
franciscojoray
changed the title
peer-sharing protocol modulepeer-sharing protocol module
franciscojoray
changed the title
peer-sharing protocol modulepeersharing protocol module
scarmuega
reviewed
Jan 6, 2025
| let msg = Message::ShareRequest(amount); | ||
| self.send_message(&msg).await?; | ||
| self.0 = State::Busy(amount); | ||
| debug!("sent share request message with amount {}", amount); |
Member
There was a problem hiding this comment.
no need for string interpolation in debug! traces. It's better to pass values as args to the macro.
Contributor
Author
There was a problem hiding this comment.
Thanks Santiago. Fixed it in the last commit.
scarmuega
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of the
peersharingprotocol.