Skip to content

feat: pallas validate crate implementation 1st pass#607

Merged
scarmuega merged 21 commits into
txpipe:mainfrom
Mercurial:feat/initial-pallas-validate-crate-implementation
Feb 27, 2025
Merged

feat: pallas validate crate implementation 1st pass#607
scarmuega merged 21 commits into
txpipe:mainfrom
Mercurial:feat/initial-pallas-validate-crate-implementation

Conversation

@Mercurial
Copy link
Copy Markdown
Contributor

No description provided.

@Mercurial Mercurial requested a review from scarmuega February 19, 2025 02:12
Comment thread pallas-validate/Cargo.toml Outdated
@Mercurial Mercurial requested a review from scarmuega February 25, 2025 16:10
@Mercurial
Copy link
Copy Markdown
Contributor Author

We discovered a bug that pallas is overriding the redeemer structure into array instead of leaving it alone. in Conway redeemers have now two types array and map so if a tx uses the map and pallas overrides the map into array then the script_data_hash changes

@scarmuega
Copy link
Copy Markdown
Member

Looks good, just two comments:

  • remove duplicated entry on workspace
  • add phase2 feature flag to pallas-validate and pallas

@scarmuega scarmuega merged commit d9d71fb into txpipe:main Feb 27, 2025
@github-project-automation github-project-automation Bot moved this to ✅ Done in Development Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants