Skip to content

Remove kes cli crate#704

Merged
scarmuega merged 4 commits into
txpipe:mainfrom
paweljakubas:paweljakubas/remove-kes-cli
Sep 19, 2025
Merged

Remove kes cli crate#704
scarmuega merged 4 commits into
txpipe:mainfrom
paweljakubas:paweljakubas/remove-kes-cli

Conversation

@paweljakubas
Copy link
Copy Markdown
Contributor

As clap is the source of problems for libraries that use pallas and that it might be not the best place to have CLI app, this PR removes kes-cli along with the traces that point to it

@paweljakubas
Copy link
Copy Markdown
Contributor Author

FYI @scarmuega

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the kes-cli crate from the Pallas workspace to address dependency conflicts with clap that affect libraries using Pallas. The removal also cleans up references to the CLI tool in documentation.

  • Removes the entire kes-cli crate directory and its implementation
  • Updates workspace configuration to exclude the removed crate
  • Removes CLI documentation and examples from the KES README
  • Cleans up unused imports in validation code

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

File Description
Cargo.toml Removes kes-cli from workspace members
pallas-crypto/src/kes/README.md Removes CLI documentation section and Cardano CLI interoperability examples
pallas-validate/src/phase1/conway.rs Removes unused imports from pallas_traverse
kes-cli/ (entire directory) Complete removal of CLI crate including source code, tests, and configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@scarmuega scarmuega merged commit 0fa819d into txpipe:main Sep 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants