Remove kes cli crate#704
Merged
Merged
Conversation
Contributor
Author
|
FYI @scarmuega |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the kes-cli crate from the Pallas workspace to address dependency conflicts with clap that affect libraries using Pallas. The removal also cleans up references to the CLI tool in documentation.
- Removes the entire
kes-clicrate directory and its implementation - Updates workspace configuration to exclude the removed crate
- Removes CLI documentation and examples from the KES README
- Cleans up unused imports in validation code
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Removes kes-cli from workspace members |
| pallas-crypto/src/kes/README.md | Removes CLI documentation section and Cardano CLI interoperability examples |
| pallas-validate/src/phase1/conway.rs | Removes unused imports from pallas_traverse |
| kes-cli/ (entire directory) | Complete removal of CLI crate including source code, tests, and configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AndrewWestberg
approved these changes
Sep 16, 2025
scarmuega
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
clapis the source of problems for libraries that usepallasand that it might be not the best place to have CLI app, this PR removeskes-clialong with the traces that point to it