Skip to content

fix(utxorpc): forward v1alpha/v1beta service features from utxorpc-spec#746

Merged
scarmuega merged 1 commit into
mainfrom
fix/utxorpc-spec-service-features
May 2, 2026
Merged

fix(utxorpc): forward v1alpha/v1beta service features from utxorpc-spec#746
scarmuega merged 1 commit into
mainfrom
fix/utxorpc-spec-service-features

Conversation

@scarmuega
Copy link
Copy Markdown
Member

Summary

  • utxorpc-spec 0.19 gated each service module (query, submit, sync, watch) behind its own cargo feature. pallas-utxorpc was only forwarding the *-cardano features, so spec::query/submit/sync/watch disappeared from the re-export at pallas::interop::utxorpc::spec.
  • Downstream consumers that implement u5c gRPC services (e.g. dolos) failed to compile against main with errors like cannot find ``submit`` in ``spec``` (item gated behind utxorpc-v1alpha-submit`).
  • Forwards the four service features for both v1alpha and v1beta so the re-export stays complete. Cardano features are pulled in transitively by each service feature.

Why explicit features (not default-features = true)

utxorpc-spec's default is proto_full, which also enables utxorpc-v1alpha-bitcoin, utxorpc-v1beta-bitcoin, and utxorpc-v1beta-handshake. Pallas is a Cardano-focused crate; re-exporting bitcoin protos at pallas::interop::utxorpc::spec would be semantic noise. The explicit list also keeps pallas insulated from future changes to proto_full.

Test plan

  • cargo check -p pallas-utxorpc passes
  • Verified locally that dolos (which uses pallas::interop::utxorpc::spec::{query,submit,sync,watch}) compiles against this branch — the previous "configured out" errors are gone
  • CI green

🤖 Generated with Claude Code

utxorpc-spec 0.19 gated each service module (query, submit, sync, watch)
behind its own cargo feature. pallas-utxorpc only forwarded the cardano
features, so spec::query/submit/sync/watch disappeared from the
re-export at pallas::interop::utxorpc::spec, breaking downstream
consumers that build u5c gRPC services (e.g. dolos).

Enable the four service features for both v1alpha and v1beta so the spec
re-export stays complete. The cardano features are pulled in transitively.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@scarmuega has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 47 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6cb5a474-b11a-4d0b-9287-950ae7432fba

📥 Commits

Reviewing files that changed from the base of the PR and between a29700a and 3eef1f6.

📒 Files selected for processing (1)
  • pallas-utxorpc/Cargo.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/utxorpc-spec-service-features

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 9 minutes and 47 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit 0da71c2 into main May 2, 2026
13 of 15 checks passed
@scarmuega scarmuega deleted the fix/utxorpc-spec-service-features branch May 2, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant