fix(utxorpc): forward v1alpha/v1beta service features from utxorpc-spec#746
Conversation
utxorpc-spec 0.19 gated each service module (query, submit, sync, watch) behind its own cargo feature. pallas-utxorpc only forwarded the cardano features, so spec::query/submit/sync/watch disappeared from the re-export at pallas::interop::utxorpc::spec, breaking downstream consumers that build u5c gRPC services (e.g. dolos). Enable the four service features for both v1alpha and v1beta so the spec re-export stays complete. The cardano features are pulled in transitively. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 9 minutes and 47 seconds.Comment |
Summary
utxorpc-spec0.19 gated each service module (query,submit,sync,watch) behind its own cargo feature.pallas-utxorpcwas only forwarding the*-cardanofeatures, sospec::query/submit/sync/watchdisappeared from the re-export atpallas::interop::utxorpc::spec.mainwith errors likecannot find ``submit`` in ``spec``` (item gated behindutxorpc-v1alpha-submit`).Why explicit features (not
default-features = true)utxorpc-spec's default isproto_full, which also enablesutxorpc-v1alpha-bitcoin,utxorpc-v1beta-bitcoin, andutxorpc-v1beta-handshake. Pallas is a Cardano-focused crate; re-exporting bitcoin protos atpallas::interop::utxorpc::specwould be semantic noise. The explicit list also keeps pallas insulated from future changes toproto_full.Test plan
cargo check -p pallas-utxorpcpassespallas::interop::utxorpc::spec::{query,submit,sync,watch}) compiles against this branch — the previous "configured out" errors are gone🤖 Generated with Claude Code