chore: declare MSRV (1.88) and verify in CI#765
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
[workspace.package].rust-version, inherited by all 22 member crates withrust-version.workspace = true.msrvCI job pinned todtolnay/rust-toolchain@1.88that runscargo check --workspace --locked --all-targetsso any regression — code or transitive dep update — breaks CI.README.md.Why 1.88
pallas-network2uses edition 2024 → hard floor of 1.85.serde_with 3.19.0anddarling 0.23.0, both of which require rustc 1.88. That's the real-world floor today.Verified locally with
cargo +1.88 check --workspace --locked --all-targets— clean.Test plan
MSRV (1.88)job passesTest,Clippy,Docs,Featuresjobs continue to pass