Skip to content

feat: Use era-agnostic address strings#54

Merged
scarmuega merged 1 commit intomainfrom
feat/addr-string
Jul 23, 2022
Merged

feat: Use era-agnostic address strings#54
scarmuega merged 1 commit intomainfrom
feat/addr-string

Conversation

@scarmuega
Copy link
Copy Markdown
Member

No description provided.

@scarmuega scarmuega requested a review from matiwinnetou July 23, 2022 12:39
@scarmuega scarmuega marked this pull request as ready for review July 23, 2022 12:39
Comment thread src/enrich/sled.rs
.iter()
.flat_map(|tx| tx.inputs())
.filter_map(|input| input.output_ref())
.map(|input| input.output_ref())
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this some bug fix?

Copy link
Copy Markdown
Member Author

@scarmuega scarmuega Jul 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to accommodate for a change upstream. The output_ref call now returns the value without a Option<> wrapper. This code has the same effect as before.

Comment thread src/reducers/total_transactions_count_by_addresses.rs
@scarmuega scarmuega merged commit d4ede65 into main Jul 23, 2022
@scarmuega scarmuega deleted the feat/addr-string branch July 23, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants