fix : Surfpool not providing : TPU, gossip, QUIC etc information requ…#473
fix : Surfpool not providing : TPU, gossip, QUIC etc information requ…#473MicaiahReid merged 5 commits intotxtx:mainfrom
Conversation
|
@MicaiahReid @lgalabru I fixed this issue review it and let me know if any changes needed |
|
@MicaiahReid @lgalabru guys if you can review and merge this i can work on the another PR #352 |
|
Hey, thanks for the PR, @subhdotsol. TBH, much of the info you've added to the response isn't relevant - we aren't serving gossip/tpu/tpu quick endpoints, so they shouldn't be listed. TBH I don't really understand the relevance of this endpoint in the first place for a surfnet - the endpoint returns info about nodes in the cluster, and surfnets aren't part of the cluster. However, I supposed I'd be open to merging a PR adding the RPC/pubsub address for this specific surfnet. |
.gitignore
Outdated
| surfpool.log | ||
| reproduce_issue.sh | ||
|
|
There was a problem hiding this comment.
Could we undo these changes?
Upon further context from @Tinkercad580, I think I'm in favor of this PR. Would love to get @lgalabru's take before merging. |
lgalabru
left a comment
There was a problem hiding this comment.
Let's ship it! thanks @subhdotsol!
Surfpool was playing hard to get getClusterNodes was returning null for critical network ports, leaving testing tools in the dark. I've hardwired the RpcConfig directly into the runtime loop, enabling Surfpool to accurately report its TPU, Gossip, and QUIC ports (defaulting to standard Solana ports 8001, 8003, 8004). Now external tools can finally handshake with the node properly.