fix(core): implement missing geyser plugin updates#490
Merged
MicaiahReid merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
lgalabru
reviewed
Jan 20, 2026
crates/core/Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = ["sqlite"] | ||
| default = ["sqlite", "geyser_plugin"] |
Member
There was a problem hiding this comment.
We did some back and forth regarding this a few times, I don't think we should enable geyser by default.
Our pre-built binaries are built with that feature and that feels like a good compromise. The geyser feature requires a bunch of highly specific dependencies (per OS, per setup, etc) and we'd be exposing ourselves to some troubleshooting support, for beginners who just want to get a basic flavor of surfpool built from source, while sophisticated builders using geyser and want to build from source can figure this out.
Member
Author
There was a problem hiding this comment.
Yep, this was an accidental commit, good catch!
lgalabru
requested changes
Jan 20, 2026
Member
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Looking sharp, thanks @MicaiahReid!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311