Skip to content

Refactor loader to be less brittle#124

Merged
ty-porter merged 4 commits intomainfrom
adapter-loading-refactor
Mar 9, 2026
Merged

Refactor loader to be less brittle#124
ty-porter merged 4 commits intomainfrom
adapter-loading-refactor

Conversation

@ty-porter
Copy link
Copy Markdown
Owner

Updates the adapter loading pattern. Rather than try to load all adapters when initializing the adapters package, create an adapter loader class that can handle this

Notes:

  • Previously had a circular import on emulator config classes, so the adapter loader had to read the config JSON directly outside the normal code paths
  • Now loads in order and stops as soon as a valid display adapter is found
  • Gets rid of the wonky suppress_adapter_load_errors setting that was defaulted false. Still get errors, but now it's only if you completely fail fallbacks.
  • Adds a fallback setting to support ☝🏻

@ty-porter ty-porter merged commit 1c3496f into main Mar 9, 2026
6 checks passed
@ty-porter ty-porter deleted the adapter-loading-refactor branch March 9, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant