Skip to content

Add public-facing types to graphics and canvas APIs#127

Merged
ty-porter merged 1 commit intoty-porter:mainfrom
WardBrian:type-public-api
Mar 27, 2026
Merged

Add public-facing types to graphics and canvas APIs#127
ty-porter merged 1 commit intoty-porter:mainfrom
WardBrian:type-public-api

Conversation

@WardBrian
Copy link
Copy Markdown
Collaborator

@WardBrian WardBrian commented Mar 27, 2026

This lets downstream code get better typechecking using an incantion like this:

from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from RGBMatrixEmulator.emulation.canvas import Canvas
    from RGBMatrixEmulator import graphics

ty-porter
ty-porter approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@ty-porter ty-porter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ty-porter ty-porter merged commit b9d4833 into ty-porter:main Mar 27, 2026
@WardBrian WardBrian deleted the type-public-api branch March 27, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ty-porter ty-porter ty-porter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WardBrian @ty-porter