Schema generator #14
Merged
Schema generator #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dredozubov
reviewed
Feb 15, 2019
src/Data/Schematic/Generator.hs
Outdated
| @@ -0,0 +1,118 @@ | |||
| {-# OPTIONS_GHC -fno-warn-orphans #-} | |||
Contributor
There was a problem hiding this comment.
Is there a reason to have these instances separately? It's possible to extract the definitions from Data.Schematic.Schema to something like Data.Schematic.Schema.Types or use mutual recursive modules so we won't have these orphan instances https://downloads.haskell.org/~ghc/7.0.3/docs/html/users_guide/separate-compilation.html
dredozubov
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added schema generator using SmallCheck series.
Fixed
Serialinstances forJsonRepr.Fixed string length predicates.