Skip to content

Conversation

@tansongyang
Copy link
Contributor

This was my first go at a *-addon generator. Like *-test, it also required copying some files from the ember.js repo.

@chriskrycho
Copy link
Member

Thanks, @tansongyang! You're just knocking these out like crazy! To fix the lint error:

/home/travis/build/typed-ember/ember-cli-typescript/blueprints/helper-test/index.js
  4:34  error  "ember-cli-is-package-missing" is extraneous  node/no-extraneous-require

Just add "ember-cli-is-package-missing" to the package.json. Easiest way I've been doing it is just yarn add ember-cli-is-package-missing.

@chriskrycho
Copy link
Member

chriskrycho commented Feb 10, 2018

Oh, and as a quick related note: you should be able to catch this kind of lint problem by doing yarn run lint:js (defined here in package.json). That'll drop your personal cycle time since we don't have to wait on Travis for it.

@@ -0,0 +1 @@
export { default, <%= camelizedModuleName %> } from '<%= modulePath %>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfreeman is this kind of re-export going to work/compile properly as TypeScript? I think the answer we got to was yes, everything works except things in app/ in the root of an addon but wanted to confirm.

Copy link
Member

@dfreeman dfreeman Feb 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want these to just be .js files (since this is going to land in app/ in the root of the addon) — I can open a PR to update the blueprints we have in place

@chriskrycho chriskrycho merged commit 7f3f0ab into typed-ember:master Feb 10, 2018
chriskrycho added a commit that referenced this pull request Feb 10, 2018
dfreeman pushed a commit that referenced this pull request Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants