Skip to content

Conversation

@krishnangovindraj
Copy link
Member

Usage and product changes

Makes TypeDB console runner use the same java installation as the calling process, so the system remain hermetic.

Implementation

  • Sets JAVA_HOME for the console subprocess to the java.home system property of the host process.

@typedb-bot
Copy link
Member

typedb-bot commented Jan 15, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@krishnangovindraj krishnangovindraj self-assigned this Jan 15, 2024
@krishnangovindraj krishnangovindraj changed the title Make TypeDB console runner use the same java installation as the calling process Make console runner use the same java installation as the calling process Jan 15, 2024
@flyingsilverfin flyingsilverfin merged commit 74e45a9 into typedb:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants