Skip to content

Conversation

@sam-butcher
Copy link
Member

What is the goal of this PR?

We add dependencies for performing JSON serialization during Ktor HTTP requests and contacting Stripe with Kotlin.

What are the changes implemented in this PR?

We add the required libraries: stripe-java, ktor-client-content-negotiation-jvm, and ktor-serialization-gson-jvm

@typedb-bot
Copy link
Member

typedb-bot commented Feb 1, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@sam-butcher sam-butcher requested a review from lolski February 2, 2024 17:35
@sam-butcher sam-butcher requested a review from a user February 2, 2024 17:35
@typedb-bot typedb-bot assigned ghost Feb 2, 2024
@sam-butcher sam-butcher added priority: high dependencies Pull requests that update a dependency file labels Feb 2, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sam-butcher sam-butcher merged commit e0e7b9d into typedb:development Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants