Skip to content

Conversation

@alexjpwalker
Copy link
Member

What is the goal of this PR?

We upgraded Client Python to the latest version, which should fix intermittent and common test failures in CI.

What are the changes implemented in this PR?

Our CI jobs have been failing for some time due to a "metadata elements leaked" error, which we've fixed in Client Python in typedb/typedb-driver-python#266, and now we've upgraded to the latest release of Client Python.

@typedb-bot
Copy link
Member

typedb-bot commented Nov 1, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

correctness:
build:
image: vaticle-ubuntu-21.04
image: vaticle-ubuntu-20.04
Copy link
Member Author

@alexjpwalker alexjpwalker Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to run a script that is incompatible with Python 3.10.

We've agreed to use this as a temporary workaround, with James currently working on a more robust solution that uses pyenv where necessary to fix the Python version.

@flyingsilverfin flyingsilverfin merged commit 91eee5e into typedb:master Nov 1, 2022
@alexjpwalker alexjpwalker deleted the python-leak-ci branch November 1, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants