Support new graql update queries #177
Conversation
.grabl/automation.yml
Outdated
| bazel test //test/behaviour/graql/language/define:checkstyle --test_output=streamed | ||
| bazel test //test/behaviour/graql/language/define:test-core --test_output=streamed --jobs=1 | ||
| bazel test //test/behaviour/graql/language/undefine:checkstyle --test_output=streamed | ||
| bazel test //test/behaviour/graql/language/undefine:test-core --test_output=streamed --jobs=1 |
There was a problem hiding this comment.
Why are these split up? We can simply write bazel test //test/behaviour/graql/language/define/... and the same for undefine. With --jobs=1 of course. Also there is no need for streamed test output - --test_output=errors should be enough.
(For the record, streamed test output results in job logs easily exceeding 10,000 lines)
There was a problem hiding this comment.
Split up due to cluster tests not presently functioning. Otherwise addressed
| return | ||
|
|
||
| #TODO: REMOVE THIS ONCE THE CRASHES ARE FIXED | ||
| time.sleep(1) |
There was a problem hiding this comment.
after_scenario is literally run after every single scenario. Given that each Graql language file has around 60-140 scenarios, and we run Core and Cluster versions of each feature, this will easily add 4 minutes to the overall runtime in CI.
We fixed a similar issue in Cluster by adding a 0.01 second sleep. I would propose we do the same here.
| time.sleep(1) | |
| time.sleep(0.01) |
|
|
||
| def after_all(context: Context): | ||
| #TODO: REMOVE THIS ONCE THE CRASHES ARE FIXED | ||
| time.sleep(1) |
There was a problem hiding this comment.
See above, but since this is after_all it's less important.
Co-authored-by: Alex Walker <alexjpwalker@gmail.com>
5 participants
What is the goal of this PR?
We synchronised client-python with the current master versions of protocol, behavioural tests, and grakn core server, to enable support for the new update query type, as well as adding support for related tests and automation.
What are the changes implemented in this PR?
Closes #176