This repository was archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Support generalised annotations and uniqueness #293
Merged
flyingsilverfin
merged 33 commits into
typedb:master
from
flyingsilverfin:unique-annotation
May 19, 2023
Merged
Support generalised annotations and uniqueness #293
flyingsilverfin
merged 33 commits into
typedb:master
from
flyingsilverfin:unique-annotation
May 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
commented
May 18, 2023
| ## Dependencies | ||
|
|
||
| typedb-protocol==2.17.0 | ||
| typedb-protocol==2.18.0.dev0 |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python's new conventions means we have to use properly named pre-releases. Until python can be a rust-wrapped client, we will use this convention and release snapshots for Python manually.
…n't contain the trailing : either
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We update the Typedb Protocol and TypeQL to the latest versions, which support the uniqueness annotation and generalised
TypeAPIs. These generalised APIs allow querying by a set of annotations, rather than just boolean =true|false.For example, the API:
AttributeType.get_owners(onlyKey: boolean), has become:AttributeType.get_owners(annotations: Set["Annotation"])All usages of boolean flags to indicate key-ness should be replaced by a set of
ThingType.AnnotationEnum.KEY. The new@uniqueannotation is available asThingType.AnnotationEnum.KEY, and also usable within the APIs that accept annotations.What are the changes implemented in this PR?
behaviourrepository to include tests for generalised annotations*_keyboolean and replace it with a set of flags fromThingType.AnnotationRelated protocol changes: typedb/typedb-protocol#182 and typedb/typedb-protocol@de4f5b4
Related core changes: typedb/typedb#6775 , typedb/typedb@e24cfa9 , and typedb/typedb@b16cdb0