Use token-based authentication for npm deployment #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjpwalker
commented
Jan 11, 2022
| image: vaticle-ubuntu-21.04 | ||
| command: | | ||
| curl https://cli-assets.heroku.com/apt/release.key | sudo apt-key add - | ||
| wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add - |
Member
Author
There was a problem hiding this comment.
Update CI scripts: we no longer need username/email/password for authentication when deploying the npm package - we just need a reusable auth token.
The token used depends on which repo we're deploying to, snapshot or release.
|
|
||
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | ||
|
|
||
| def vaticle_dependencies(): |
Member
Author
There was a problem hiding this comment.
Update to dependencies that gives us access to the token-based deploy_npm rule
alexjpwalker
commented
Jan 11, 2022
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | ||
|
|
||
| def vaticle_dependencies(): | ||
| git_repository( |
Member
Author
There was a problem hiding this comment.
Update to dependencies that gives us access to the token-based deploy_npm rule
lolski
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
The npm deployment infrastructure now uses token-based authentication instead of username/password authentication.
What are the changes implemented in this PR?
See typedb/bazel-distribution#330 for an explanation of why this PR is necessary.
deploy_npmuse token authentication) and automation.yml (to pass the token in)