Add get_node_type accessor, migrate type-only callers#42
Merged
Conversation
Add get_node_type(graph, id) -> NodeType as an ECS-style property accessor. Migrate 6 production callers that used get_file_node() solely to check node->type: - scheduler.cpp: 3 callers (Group/Ghost type checks) - config_commands.cpp: 1 caller (Group type check) - cmd_build.cpp: 1 caller (Generated type check) - cmd_show.cpp: 1 caller (Generated/File filter) cmd_build.cpp's index-building code still uses get_file_node() for full node access (parent_dir, flags, type) — deeper ECS migration requires additional property accessors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step toward ECS-style property accessors — add
get_node_type(graph, id) -> NodeTypeand migrate 6 production callers that usedget_file_node()solely to readnode->type.The
get_file_node()pattern for type checks was:Now:
if (get_node_type(graph, id) == NodeType::Group) { ... }One caller (
cmd_build.cppindex construction) still needsget_file_node()for full node access (parent_dir, flags, type) — deeper migration requires additional property accessors.Test plan
clang-formatclean🤖 Generated with Claude Code