fix: resolve master password prompt issues for new and returning users#1
Merged
fix: resolve master password prompt issues for new and returning users#1
Conversation
- Fix useMasterPassword hook to prompt new users without master password - Fix returning users not being prompted after sign-out/sign-in - Fix API initialization order to prevent 500 errors - Add reinitialize function to properly reload data after password setup - Update MainLayout to handle password unlock flow correctly This ensures all users are prompted for master password as expected: - New users: prompted to create master password - Returning users: prompted to unlock with existing password - No more API 500 errors during user initialization
Contributor
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The master password system had critical flaws that allowed users to bypass encryption entirely:
This defeated the purpose of having end-to-end encryption, as the security was completely optional.
✅ Solution
Fixed the master password flow to ensure all users must set up and use master password protection:
Key Changes:
useMasterPasswordhook logic:- Only call api.getCurrentUser() after master password is properly set up
- Prevents 500 errors from premature API calls
- New reinitialize() function to reload data after password setup
- Ensures smooth transition from password setup to app usage
🔒 Security Impact
🧪 Testing
📝 Files Changed
This ensures the master password system works as designed - providing true end-to-end encryption that cannot be bypassed.