Roll back to Scala.js 1.5.1#185
Merged
Merged
Conversation
Pins back to our previously released version. We can bump later if that comes back into fashion, but we can't unbump.
Member
Author
|
@armanbilge, did I do something stupid? I thought this was just like typelevel/cats#4018. I was being ultraconservative before a release, but I'm just going to close this unless someone can point out my mistake within a 10-second glance. |
Member
|
I think we need to roll back another dependency, that's already bumped to SJS 1.7. I suspect #183, checking now. |
Member
Author
|
Thanks. I would not spend much time: this isn't that important, given the shortage of scars on the Scala.js side and that almost all use is with http4s with 1.7. |
Member
|
Ok my bad, it was #168. You need to bump that back to 1.2.0. |
Member
Author
|
I'm ambivalent on this one, but last chance to do it before I cut 1.2.0. |
Member
Author
|
Relates to typelevel/cats#4018. It's reversible if we merge, but not reversible if we release without. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins back to our previously released version. We can bump later if that comes back into fashion, but we can't unbump.