Update Twitter Util to 7.1.0 (and switch to SBT 1.0)#47
Merged
travisbrown merged 2 commits intomasterfrom Sep 10, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 65.61% 65.61%
=======================================
Files 12 12
Lines 253 253
Branches 2 2
=======================================
Hits 166 166
Misses 87 87Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should be separate PRs but I'm in a hurry. I've removed WartRemover because I've never really found it useful for this project and it's not available for SBT 1.0.
Of course the SBT upgrade breaks random stuff (in this case incremental compilation, apparently): if you check out 60ac81d, build, then check out 132b612 and build again, you get this error:
Cleaning fixes it, and I don't really care enough to try to figure out why it's happening.