Skip to content

Update Twitter Util to 7.1.0 (and switch to SBT 1.0)#47

Merged
travisbrown merged 2 commits intomasterfrom
update/finagle-7.1.0
Sep 10, 2017
Merged

Update Twitter Util to 7.1.0 (and switch to SBT 1.0)#47
travisbrown merged 2 commits intomasterfrom
update/finagle-7.1.0

Conversation

@travisbrown
Copy link
Copy Markdown
Contributor

These should be separate PRs but I'm in a hurry. I've removed WartRemover because I've never really found it useful for this project and it's not available for SBT 1.0.

Of course the SBT upgrade breaks random stuff (in this case incremental compilation, apparently): if you check out 60ac81d, build, then check out 132b612 and build again, you get this error:

[error] Symbol 'type io.catbird.finagle.ServiceInstances' is missing from the classpath.
[error] This symbol is required by 'package io.catbird.finagle.package'.
[error] Make sure that type ServiceInstances is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'package.class' was compiled against an incompatible version of io.catbird.finagle.
[error] one error found

Cleaning fixes it, and I don't really care enough to try to figure out why it's happening.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 10, 2017

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   65.61%   65.61%           
=======================================
  Files          12       12           
  Lines         253      253           
  Branches        2        2           
=======================================
  Hits          166      166           
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfabdf...132b612. Read the comment docs.

@travisbrown travisbrown merged commit 6bfb666 into master Sep 10, 2017
@bpholt bpholt deleted the update/finagle-7.1.0 branch May 11, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants