Converted startup runtime collision into a warning#2202
Merged
Conversation
djspiewak
force-pushed
the
bug/ioapp-init
branch
from
3ff51d9 to
90e9e11
Compare
vasilmkd
reviewed
Aug 5, 2021
vasilmkd
left a comment
vasilmkd
left a comment
Member
There was a problem hiding this comment.
Bummer, it looks like you forgot the mima filters.
vasilmkd
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918
When the global runtime is already initialized by the time
mainruns, we now treat this as a warning (which prints to stderr) rather than a fatal error (which is what we did previously). The warning is still important because the user really needs to know that we're ignoring their custom configurations.We can probably do better than the text on this warning and give the user some actionable steps to track down why the warning is appearing.