Skip to content

Conversation

@julien-truffaut
Copy link
Contributor

fix #2852

I am not sure if it is binary compatible since Applicative extends Monad and it is in a Contravariant position.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #2854 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2854   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         368      368           
  Lines        6944     6944           
  Branches      301      308    +7     
=======================================
  Hits         6542     6542           
  Misses        402      402
Impacted Files Coverage Δ
core/src/main/scala/cats/Foldable.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f1193...608b1ff. Read the comment docs.

@kailuowang
Copy link
Contributor

This is not BC, once we drop Scala 2.11 on master, we can add a foldMapA for this if it helps.

@julien-truffaut
Copy link
Contributor Author

@kailuowang yeah that's what I expected but I wasn't sure. Should I revert my last commit and add foldMapA? We can merge this whenever 2.11 is dropped

@kailuowang
Copy link
Contributor

Yeah, let's do that. It will be a bit more work though since you need to add tests.

@LukaJCB
Copy link
Member

LukaJCB commented May 23, 2019

Shall we add foldA at that point as well? :)

@julien-truffaut
Copy link
Contributor Author

I don't have the bandwidth to finish the work, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce constraint for foldMapM

4 participants