Skip to content

Change concurrency class to handle more complex expressions for cancellation.#861

Merged
armanbilge merged 6 commits intotypelevel:mainfrom
zarthross:cancel-in-progress
Feb 27, 2026
Merged

Change concurrency class to handle more complex expressions for cancellation.#861
armanbilge merged 6 commits intotypelevel:mainfrom
zarthross:cancel-in-progress

Conversation

@zarthross
Copy link
Copy Markdown
Contributor

Github actions allows you to set cancellation based on an expression.
Changing the cancelInProgress to a string allows me to set the
cancellation based on branch which would help my team prevent
cancellation of main branch builds in the middle of an automatic publish
leaving us in a half published state.

Example:
docs

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ !contains(github.ref, 'release/')}}

…llation.

Github actions allows you to set cancellation based on an expression.
Changing the cancelInProgress to a string allows me to set the
cancellation based on branch which would help my team prevent
cancellation of main branch builds in the middle of an automatic publish
leaving us in a half published state.
@zarthross
Copy link
Copy Markdown
Contributor Author

Can someone look at this? I know its bin-breaking but it adds a lot of flexibility for cancellation thats very much needed.

@zarthross
Copy link
Copy Markdown
Contributor Author

@armanbilge ?

Copy link
Copy Markdown
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good change. With a tiny bit of nuisance we can make it compatibly, what do you think?

@zarthross zarthross requested a review from armanbilge February 9, 2026 17:25
@zarthross
Copy link
Copy Markdown
Contributor Author

Thanks, this is good change. With a tiny bit of nuisance we can make it compatibly, what do you think?

I liked it, I finished fleshing it out. Ready for a re-review @armanbilge

Copy link
Copy Markdown
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just need to add MiMa exceptions for the private Impl class.

@zarthross
Copy link
Copy Markdown
Contributor Author

@armanbilge Corrected the mima warnings.

Copy link
Copy Markdown
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that follow-up. Nicely done!

@armanbilge armanbilge merged commit d08ad8e into typelevel:main Feb 27, 2026
16 checks passed
@zarthross zarthross deleted the cancel-in-progress branch February 27, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants