Update scalacOptions for Scala 3.8#892
Merged
Merged
Conversation
This is done silently, as chosing Scala 3.8+ is opting into JDK 17+
armanbilge
approved these changes
May 20, 2026
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
formatting nitpicks sorry!
Comment on lines
+298
to
+301
| case V(V(3, minor, _, _)) if minor >= 2 => | ||
| javaOutputVersionOption | ||
| if (minor <= 7) { | ||
| javaOutputVersionOption | ||
| } else { |
Member
There was a problem hiding this comment.
Sorry to nitpick, maybe instead of the nested if-else it would be nicer to extract this as a separate case ?
samspills
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exactly PR #860 by @xuwei-k, with the change requested by @armanbilge. That PR has been open for months pending a small change, and it's blocking my projects. By the power of open source I decided to submit the change myself. 😄