Remove dependency on scram client in favor of native implementation#1288
Merged
Remove dependency on scram client in favor of native implementation#1288
Conversation
armanbilge
approved these changes
Apr 20, 2026
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
awesome that this ended up being useful for the JVM too 😁
| "org.typelevel" %%% "otel4s-semconv-metrics" % otel4sVersion, | ||
| "org.tpolecat" %%% "sourcepos" % "1.2.0", | ||
| "org.typelevel" %%% "twiddles-core" % "1.0.0", | ||
| "com.armanbilge" %%% "saslprep" % "0.1.2", |
Member
There was a problem hiding this comment.
Not urgent, but since it's becoming a core depedency we could move this under org.typelevel and 1.0? I can do that.
Member
Author
There was a problem hiding this comment.
Yeah that would be great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1287 that avoids a third party dependency entirely by reusing the JS/Native implementation for JVM.