Reduce unnecessary string allocation when debug is disabled in MessageSocket

[mpilquist]

No description provided.

[codecov]

Codecov Report

Merging #761 (755e041) into main (d9b5b59) will decrease coverage by 2.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   87.18%   85.12%   -2.06%     
==========================================
  Files         111      124      +13     
  Lines        1506     1661     +155     
  Branches      125      121       -4     
==========================================
+ Hits         1313     1414     +101     
- Misses        193      247      +54     

Impacted Files	Coverage Δ
...core/shared/src/main/scala/net/MessageSocket.scala	100.00% <100.00%> (ø)
modules/core/shared/src/main/scala/Fragment.scala	100.00% <0.00%> (ø)
...dules/core/shared/src/main/scala/Transaction.scala	30.95% <0.00%> (ø)
...shared/src/main/scala-2.13+/data/ArrPlatform.scala	100.00% <0.00%> (ø)
...re/shared/src/main/scala/codec/NumericCodecs.scala	100.00% <0.00%> (ø)
...odules/core/js-jvm/src/main/scala-2/SqlState.scala	100.00% <0.00%> (ø)
...red/src/main/scala-2/syntax/StringContextOps.scala	100.00% <0.00%> (ø)
modules/core/shared/src/main/scala/Channel.scala	95.23% <0.00%> (ø)
...s/refined/src/main/scala/codec/NumericCodecs.scala	0.00% <0.00%> (ø)
...s/core/shared/src/main/scala-2/util/Twiddler.scala	100.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ybasket]

Wouldn't that evaluate msg still as println takes a strict argument? I expected something like

Suggested change

	Console[F].println(msg).whenA(debugEnabled)
	Applicative[F].whenA(debugEnabled)(Console[F].println(msg))

which takes a => F[A].

Edit: Sorry, forget this, I was looking at an outdated version of the whenA syntax.

[armanbilge]

I think there is still a thunk allocation here, which we can avoid. There's also the thunk for the string, which we are stuck with unless we reach for macros.

Suggested change

	Console[F].println(msg).whenA(debugEnabled)
	if (debugEnabled) Console[F].println(msg) else Concurrent[F].unit