Change prepare to return F[..] instead of Resource[F, ..], add prepareR with old signature #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eR with old signature
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 84.82% 84.76% -0.06%
==========================================
Files 124 124
Lines 1667 1667
Branches 124 124
==========================================
- Hits 1414 1413 -1
- Misses 253 254 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eikek
added a commit
to SwissDataScienceCenter/renku-graph
that referenced
this pull request
Jan 18, 2023
This addresses the change from `Resource` to `F[_]`, see typelevel/skunk#764
eikek
added a commit
to SwissDataScienceCenter/renku-graph
that referenced
this pull request
Jan 18, 2023
* chore: Update skunk-core from 0.3.2 to 0.5.0 * Fix compile errors due to skunk update This addresses the change from `Resource` to `F[_]`, see typelevel/skunk#764 Co-authored-by: RenkuBot <RenkuBot@users.noreply.github.com> Co-authored-by: Eike Kettner <eike.kettner@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this sets us up better for the future, though does require folks to either rewrite their code to use
F[..]instead ofResource[F, ..]or otherwise add anRcharacter afterprepare.