Skip to content

Normalize http problem details response with templates#26

Merged
adampaquette merged 8 commits intomainfrom
normalize-asp-response
May 1, 2023
Merged

Normalize http problem details response with templates#26
adampaquette merged 8 commits intomainfrom
normalize-asp-response

Conversation

@adampaquette
Copy link
Collaborator

No description provided.

@adampaquette adampaquette marked this pull request as ready for review May 1, 2023 01:59
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (89236a3) 93.75% compared to head (01e8baf) 93.93%.

❗ Current head 01e8baf differs from pull request most recent head f969fd9. Consider uploading reports for the commit f969fd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   93.75%   93.93%   +0.18%     
==========================================
  Files          55       56       +1     
  Lines        1233     1270      +37     
==========================================
+ Hits         1156     1193      +37     
  Misses         77       77              
Impacted Files Coverage Δ
...Mvc/ModelBinding/TypelyValueModelBinderProvider.cs 100.00% <ø> (ø)
src/Typely.AspNetCore/Mvc/MvcOptionsExtensions.cs 100.00% <ø> (ø)
...ly.AspNetCore/Http/ApplicationBuilderExtensions.cs 100.00% <100.00%> (ø)
...Core/Http/HttpValidationTemplatedProblemDetails.cs 100.00% <100.00%> (ø)
...c/Typely.AspNetCore/Http/TemplatedProblemDetail.cs 100.00% <100.00%> (ø)
...spNetCore/Http/TypelyValidationResultMiddleware.cs 100.00% <100.00%> (ø)
...NetCore/Mvc/ModelBinding/TypelyValueModelBinder.cs 100.00% <100.00%> (ø)
...rsing/TypeBuilders/EmittableTypeBuilderOfString.cs 91.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adampaquette adampaquette changed the title Normalize http problem response with errors templates Normalize http problem details response with templates May 1, 2023
@adampaquette adampaquette merged commit 44e484f into main May 1, 2023
@adampaquette adampaquette deleted the normalize-asp-response branch May 1, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant