Skip to content

lint: fix offenses for @typescript-eslint/no-unused-vars rule in src folder #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

lint: fix offenses for @typescript-eslint/no-unused-vars rule in src folder #11758

wants to merge 12 commits into from

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Nov 9, 2025

Description of change

Similar to #11757 but in src folder, so should be reviewed more carefully.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

@pkuczynski pkuczynski self-assigned this Nov 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 9, 2025 •
edited
Loading

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11758

commit: e2aa4d1

gioboa
gioboa approved these changes Nov 9, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

alumni
alumni reviewed Nov 12, 2025
View reviewed changes
src/driver/mysql/MysqlDriver.ts
* Creates an escaped parameter.
*/
createParameter(parameterName: string, index: number): string {
createParameter(): string {
Copy link
Collaborator

@alumni alumni Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed - it's the same signature in all drivers. It's also part of the public API, and changing it is a breaking change.

alumni
alumni requested changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@alumni alumni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method signatures should not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alumni alumni alumni requested changes

@gioboa gioboa gioboa approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@pkuczynski pkuczynski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkuczynski @alumni @gioboa