feat(dsl): accept maps and sets instead of linked versions #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
krzema12
changed the title
krzema12
changed the title
krzema12
deleted the
05-03-feat_dsl_accept_maps_instead_of_linked_hash_maps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that iterating over a map/set returned by a common map builder
mapOf/setOfcorresponds to the order given to this function. It wasn't obvious since the builder returns a regularMap/Setwhere the order is not specified. Thanks to this observation, we can simplify the API and not requirelinkedMapOf/linkedSetOfwhich is more verbose.Action bindings still operate on
LinkedHashMapbecause making this change would break the Maven-based bindings server. Leaving this type there is not that painful, it's only visible if someone decides to create a local action binding. Otherwise, the binding code is auto-generated.