Skip to content

feat(library): make outputs accessible for all steps#1589

Merged
krzema12 merged 2 commits intotypesafegithub:mainfrom
Vampire:issue-1587
Aug 14, 2024
Merged

feat(library): make outputs accessible for all steps#1589
krzema12 merged 2 commits intotypesafegithub:mainfrom
Vampire:issue-1587

Conversation

@Vampire
Copy link
Copy Markdown
Collaborator

@Vampire Vampire commented Aug 14, 2024

fixes #1587

@Vampire Vampire requested a review from krzema12 August 14, 2024 16:04
@krzema12 krzema12 changed the title feat(library): make outputs accessible for all steps (#1587) feat(library): make outputs accessible for all steps Aug 14, 2024
@krzema12 krzema12 enabled auto-merge (squash) August 14, 2024 18:06
@krzema12 krzema12 merged commit 09fa7f6 into typesafegithub:main Aug 14, 2024
@krzema12
Copy link
Copy Markdown
Member

Thanks! :)

@krzema12
Copy link
Copy Markdown
Member

@Vampire BTW, no need to work with the fork - you have write perms to this repo.

@Vampire Vampire deleted the issue-1587 branch August 14, 2024 18:09
@Vampire
Copy link
Copy Markdown
Collaborator Author

Vampire commented Aug 14, 2024

Yeah, I know, but I usually hate pulling from repos where everytime I get dozens of branches like gradle/gradle, so I usually tend to use fork everywhere even if I have write permission.

Only exception is, where I use Graphite as it does not yet support the forked-pr flow, but you did not enable the free subscription yet.

And it is not really more effort, I either way just do gh pr create and select one line or the other :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core feature request] CommandStep is missing way to access outputs

2 participants