Conversation
…ration This is a preliminary change making it easier to implement #1691. Even without the above project, it makes things more straightforward. In particular, the artifact names happen to match what comes in the request, but in general it doesn't have to be the case.
krzema12
force-pushed
the
pass-raw-name-and-raw-version-to-artifact-generation
branch
from
568a52e to
effbd69
Compare
krzema12
commented
Dec 30, 2025
| <metadata> | ||
| <groupId>owner</groupId> | ||
| <artifactId>name___$significantVersion</artifactId> | ||
| <artifactId>name</artifactId> |
Member
Author
There was a problem hiding this comment.
The only change in behavior captured by the tests, but I don't think it's really relevant. Regarding caching, the artifacts are cached by name, not this artifactId. Whether the "significant version" mechanism works in general is tested in the end-to-end tests, see:
krzema12
deleted the
pass-raw-name-and-raw-version-to-artifact-generation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary change making it easier to implement #1691.
Even without the above project, it makes things more straightforward. In particular, the artifact names happen to match what comes in the request, but in general it doesn't have to be the case. We need to encode certain extra information in Maven artifact's names and owners, which leads to a mismatch where the GitHub action's name isn't equal to the requested Maven artifact's name. This change recognizes it by using different fields in these two circumstances.